fix: spread syntax crashes in order-in-* rules

And add spread syntax configuration support to these rules.

Author: bmish

docs/rules/order-in-components.md

@@ -10,6 +10,7 @@ const rules = {
     2,
     {
       order: [
+        'spread',
         'service',
         'property',
         'empty-method',

docs/rules/order-in-controllers.md

@@ -10,6 +10,7 @@ const rules = {
     2,
     {
       order: [
+        'spread',
         'controller',
         'service',
         'query-params',

docs/rules/order-in-models.md

@@ -11,6 +11,7 @@ const rules = {
     {
       // eslint-disable-next-line prettier/prettier
       order: [
+        'spread',
         'attribute',
         'relationship',
         'single-line-function',

docs/rules/order-in-routes.md

@@ -10,6 +10,7 @@ const rules = {
     2,
     {
       order: [
+        'spread',
         'service',
         'inherited-property',
         'property',

lib/rules/order-in-components.js

@@ -7,6 +7,7 @@ const reportUnorderedProperties = propOrder.reportUnorderedProperties;
 const addBackwardsPosition = propOrder.addBackwardsPosition;
 
 const ORDER = [
+  'spread',
   'service',
   'property',
   'empty-method',

lib/rules/order-in-controllers.js

@@ -7,6 +7,7 @@ const reportUnorderedProperties = propOrder.reportUnorderedProperties;
 const addBackwardsPosition = propOrder.addBackwardsPosition;
 
 const ORDER = [
+  'spread',
   'controller',
   'service',
   'query-params',

lib/rules/order-in-models.js

@@ -6,7 +6,13 @@ const propOrder = require('../utils/property-order');
 const reportUnorderedProperties = propOrder.reportUnorderedProperties;
 const addBackwardsPosition = propOrder.addBackwardsPosition;
 
-const ORDER = ['attribute', 'relationship', 'single-line-function', 'multi-line-function'];
+const ORDER = [
+  'spread',
+  'attribute',
+  'relationship',
+  'single-line-function',
+  'multi-line-function',
+];
 
 //------------------------------------------------------------------------------
 // Organizing - Organize your models

lib/rules/order-in-routes.js

@@ -7,6 +7,7 @@ const reportUnorderedProperties = propOrder.reportUnorderedProperties;
 const addBackwardsPosition = propOrder.addBackwardsPosition;
 
 const ORDER = [
+  'spread',
   'service',
   'inherited-property',
   'property',

lib/utils/ember.js

@@ -473,7 +473,12 @@ function isRouteProperty(name) {
 }
 
 function isRouteDefaultProp(property) {
-  return isRouteProperty(property.key.name) && property.key.name !== 'actions';
+  return (
+    types.isProperty(property) &&
+    types.isIdentifier(property.key) &&
+    isRouteProperty(property.key.name) &&
+    property.key.name !== 'actions'
+  );
 }
 
 function isControllerProperty(name) {
@@ -490,7 +495,12 @@ function isControllerProperty(name) {
 }
 
 function isControllerDefaultProp(property) {
-  return isControllerProperty(property.key.name) && property.key.name !== 'actions';
+  return (
+    types.isProperty(property) &&
+    types.isIdentifier(property.key) &&
+    isControllerProperty(property.key.name) &&
+    property.key.name !== 'actions'
+  );
 }
 
 function getModuleProperties(module) {

lib/utils/property-order.js

@@ -42,6 +42,7 @@ const NAMES = {
   serialize: 'lifecycle hook',
   service: 'service injection',
   setupController: 'lifecycle hook',
+  spread: 'spread property',
   unknown: 'unknown property type',
   willClearRender: 'lifecycle hook',
   willDestroyElement: 'lifecycle hook',
@@ -60,18 +61,18 @@ function determinePropertyType(node, parentType, ORDER) {
     return 'controller';
   }
 
-  if (node.key.name === 'init') {
+  if (types.isIdentifier(node.key) && node.key.name === 'init') {
     return 'init';
   }
 
   if (parentType === 'component') {
-    if (ember.isComponentLifecycleHook(node)) {
+    if (types.isIdentifier(node.key) && ember.isComponentLifecycleHook(node)) {
       return node.key.name;
     }
   }
 
   if (parentType === 'controller') {
-    if (node.key.name === 'queryParams') {
+    if (types.isIdentifier(node.key) && node.key.name === 'queryParams') {
       return 'query-params';
     } else if (ember.isControllerDefaultProp(node)) {
       return 'inherited-property';
@@ -131,6 +132,10 @@ function determinePropertyType(node, parentType, ORDER) {
     return 'method';
   }
 
+  if (node.type === 'ExperimentalSpreadProperty') {
+    return 'spread';
+  }
+
   return 'unknown';
 }
 
@@ -166,7 +171,7 @@ function getNodeKeyName(node) {
 
 function getName(type, node) {
   let prefix;
-  if (!node.computed && type !== 'actions' && type !== 'model') {
+  if (!node.computed && type !== 'actions' && type !== 'model' && type !== 'spread') {
     prefix = getNodeKeyName(node);
   }