Merge pull request #930 from bmish/no-restricted-resolver-tests-fix-spread

Fix spread syntax crash in `no-restricted-resolver-tests` rule

Author: bmish

lib/rules/no-restricted-resolver-tests.js

@@ -32,19 +32,26 @@ function hasOnlyStringArgument(node) {
 
 function hasUnitTrue(node) {
   return node.properties.some(
-    (property) => property.key.name === 'unit' && property.value.value === true
+    (property) =>
+      types.isProperty(property) && property.key.name === 'unit' && property.value.value === true
   );
 }
 
 function hasNeeds(node) {
   return node.properties.some(
-    (property) => property.key.name === 'needs' && property.value.type === 'ArrayExpression'
+    (property) =>
+      types.isProperty(property) &&
+      property.key.name === 'needs' &&
+      property.value.type === 'ArrayExpression'
   );
 }
 
 function hasIntegrationTrue(node) {
   return node.properties.some(
-    (property) => property.key.name === 'integration' && property.value.value === true
+    (property) =>
+      types.isProperty(property) &&
+      property.key.name === 'integration' &&
+      property.value.value === true
   );
 }
 

tests/lib/rules/no-restricted-resolver-tests.js

@@ -12,13 +12,15 @@ const { ERROR_MESSAGES } = rule;
 //------------------------------------------------------------------------------
 
 const ruleTester = new RuleTester({
+  parser: require.resolve('babel-eslint'),
   parserOptions: { ecmaVersion: 6, sourceType: 'module' },
 });
 ruleTester.run('no-restricted-resolver-tests', rule, {
   valid: [
     `
     import { moduleFor } from 'ember-qunit';
     moduleFor('service:session', {
+      ...foo,
       integration: true
     });
     `,